Hello,
I have been having problems with having a general data sheet in my workbook. My problem is as follows:
I have 3 different sheets, all of which keep track of the same set of data, for purposes of this question, let's say they all keep track of:
-Id
-Name
-Random Number
They are separated in 3 different sheets because they are filled by 3 different people, as the workbook is in a network. However, the problem that I am facing is having an auto filling general sheet; as in, when the first user fills rows in their respective sheet, it auto populates in a fourth different sheet, where all the data is kept track of.
Maybe I am not making myself clear as English is not my first language, but in other words, I want a sheet to be auto populated as multiple others are filled.
System Configuration: Windows / Chrome 75.0.3770.142
This code counts the nunber of aheets. If it finds five sheets, it will combine sheet2,3,4,5 onto sheet1. You place the code in a module, from the developers tab. Then press run.
findlastrow = ThisWorkbook.Worksheets(whatsheet).Cells(Rows.Count, 1).End(xlUp).Row
End Function
Sub Combinesheets()
'this code assumes your master sheet is on the first sheet 'It will loop through each sheet and place the contents onto the first sheet
Dim tabcount
Dim tabcounter, rowcounter
Dim thevalue
tabcount = ThisWorkbook.Worksheets.Count
For tabcounter = 2 To tabcount
For rowcounter = 1 To findlastrow(tabcounter)
thevalue = ThisWorkbook.Worksheets(tabcounter).Range("A" & rowcounter).Value
ThisWorkbook.Worksheets(1).Range("A" & findlastrow(1) + 1).Value = thevalue
Next
Next
End Sub
It works great! thank you so much! Now i have two small issues though; first off, how can i modify the code for it run in a set of specific sheets, instead of all of them, and also, when the sheets get combined, they do so in columns, instead of rows; meaning that the master sheet shows all the information in a single column going down, instead of across rows
OK, in order to run only on specific sheets, we can build an array to hold the sheets that need to be run.
So, we would do something like this:
Function findlastrow(whatsheet) findlastrow = ThisWorkbook.Worksheets(whatsheet).Cells(Rows.Count, 1).End(xlUp).Row End Function
Sub Combinesheets() 'this code assumes your master sheet is on the first sheet 'It will loop through each sheet and place the contents onto the first sheet Dim tabcount Dim rowcounter Dim thevalue Dim sheetsList() sheetsList() = [{"Sheet2","Sheet4"}] ' place your sheet names here thetab = UBound(sheetsList) - LBound(sheetsList) + 1 For tabcounter = 1 To thetab For rowcounter = 1 To findlastrow(sheetsList(tabcounter)) thevalue = ThisWorkbook.Worksheets(sheetsList(tabcounter)).Cells(rowcounter, 1).Value ThisWorkbook.Worksheets(1).Range("A" & findlastrow(1) + 1).Value = thevalue Next Next End Sub
Let me pivot the list, and lay it out now. Is there a LAST Column that is standard for each line, or do we need to consider each line possibly having more or less than the previous one?
There is a last column that is standard for every single sheet, althought the actual value in the cell changes, as they all contain the same info, and they always have to have the same amount of columns
Ok, this will scrub across 26 columns. Set the variable of Z if you want a different number of columns.
Sub CombineSheets()
'this code assumes your master sheet is on the first sheet
'It will loop through each sheet and place the contents onto the first sheet
Dim tabcount
Dim rowcounter
Dim thevalue
Dim Z
Dim sheetsList()
Z = 26 ' this is the number of columns to copy to the new sheet!
sheetsList() = [{"Sheet2","Sheet4"}] ' place your sheet names here
thetab = UBound(sheetsList) - LBound(sheetsList) + 1
-For tabcounter = 1 To thetab
--------For rowcounter = 1 To findlastrow(sheetsList(tabcounter))
--------------For columnCount = 1 To Z
-------------------thevalue = ThisWorkbook.Worksheets(sheetsList(tabcounter)).Cells(rowcounter, columnCount).Value
-------------------ThisWorkbook.Worksheets(1).Cells(findlastrow(1) + 1, columnCount).Value = thevalue
--------------Next
--------Next
-Next
End Sub
I really hope you are learning how to construct a solution!
Hello Mark, yes, i am trying to learn as much as possible. Sorry for the delay between responses, i was commuting back from work, i will test this new solution as soon as possible
Hello Mark, i have been trying out the code, but the second line of code
"findlastrow = ThisWorkbook.Worksheets(whatsheet).Cells(Rows.Count, 1).End(xlUp).Row"
gives out error 9, saying that it is outside the interval, and i have yet to find a way to fix it
Ok well that is a function and it returns the last row of what ever sheet you paas in the parameter of whatsheet. Are you passing a sheet name? That function will error out if ran alone, as ot needs to passed a variable. In rhis case the variabke is the sheet that you want counted.
This ia the complete function, below.
Function findlastrow(whatsheet)
findlastrow = ThisWorkbook.Worksheets(whatsheet).Cells(Rows.Count, 1).End(xlUp).Row
End Function
It should be Sheet4, and i sustitute "whatsheet" for Sheet4, and it still doesn't run. The only way to get pass it that i find, was to include the name of all the sheets that participate in the process, but that seems incorrect too, as it tells me the "Sub" is not optional anymore
Ok, jist remove the sheet4 from the parameter. So the first line should read,
Function findlastrow ()
That should do it. BUT, IT WILL CAUSE THE MAIN SUBROUTINE TO FAIL, AS IT PASSES THE SHEET INTO THAT FUNCTION. SO, in prder to avoid changing the code, just change the sheets listed in the variable of sheetsList ().
So, sheetsList=[{"Sheet4"}]
So, please do not make this more complicated than it has to be.
Function findlastrow()
findlastrow = ThisWorkbook.Worksheets("Sheet4").Cells(Rows.Count, 1).End(xlUp).Row
End Function
Sub CombineSheets()
'this code assumes your master sheet is on the first sheet
'It will loop through each sheet and place the contents onto the first sheet
Dim tabcount
Dim rowcounter
Dim thevalue
Dim Z
Dim sheetsList()
Z = 15 ' this is the number of columns to copy to the new sheet!
sheetsList() = [{"Sheet4"}] ' place your sheet names here
thetab = UBound(sheetsList) - LBound(sheetsList) + 1
For tabcounter = 1 To thetab
For rowcounter = 1 To findlastrow(sheetsList(tabcounter))
For columnCount = 1 To Z
thevalue = ThisWorkbook.Worksheets(sheetsList(tabcounter)).Cells(rowcounter, columnCount).Value
ThisWorkbook.Worksheets(1).Cells(findlastrow(1) + 1, columnCount).Value = thevalue
Next
Next
Next
End Sub
This is what i have, and it still wont' run. I am sorry, I am starting to think you are being annoyed by this, but if you think enough's enough, we can close the topic
Ok, put the original function back the way I published it. It should run, as you are limiting the sheet in the sheetList array variable. You are so close!
Pardon me, but i thought the array's job was to tell the code what sheets it needed to go through to copy and combine in the "master sheet". Now we are using it to tell the code that the sheet that it needs to read and find last row of it's sheet 4, no?
No. You are correct with the first statement. If you wish to change the sheet it writes to, that is a different solution, and I have not addressed the configuration of that sheet.
In the bottom of the code at this line,
ThisWorkbook.Worksheets(1).Cells(findlastrow(1) + 1, columnCount).Value = thevalue
Function findlastrow()
findlastrow = ThisWorkbook.Worksheets("Sheet4").Cells(Rows.Count, 1).End(xlUp).Row
End Function
Sub CombineSheets()
'this code assumes your master sheet is on the first sheet
'It will loop through each sheet and place the contents onto the first sheet
Dim tabcount
Dim rowcounter
Dim thevalue
Dim Z
Dim sheetsList()
Z = 15 ' this is the number of columns to copy to the new sheet!
sheetsList() = [{"Sheet4"}] ' place your sheet names here
thetab = UBound(sheetsList) - LBound(sheetsList) + 1
For tabcounter = 1 To thetab
For rowcounter = 1 To findlastrow(sheetsList(tabcounter))
For columnCount = 1 To Z
thevalue = ThisWorkbook.Worksheets(sheetsList(tabcounter)).Cells(rowcounter, columnCount).Value
ThisWorkbook.Worksheets("sheet4").Cells(findlastrow(1) + 1, columnCount).Value = thevalue
Next
Next
Next
End Sub
You did not change the last line correctly. It should read as
Thisworkbook.worksheets ("sheet4").cells (findlastrow ("sheet4")+1, columnCount.Value = thevalue
I highlighted and underlined the part in your code that is incorrect. Just use the below code in its entirety.
The sheets you wish to have scrubbed and moved should be listed in the sheetList array. The sheet that you wish to copy the values to, is set by placesheet. Z is the number of columns across you wish to copy.
Function findlastrow(whatsheet) findlastrow = ThisWorkbook.Worksheets(whatsheet).Cells(Rows.Count, 1).End(xlUp).Row End Function
Sub CombineSheets() 'It will loop through each sheet and place the contents onto the sheet set by placesheet Dim tabcount Dim rowcounter Dim thevalue Dim Z Dim sheetsList() Dim placesheet
placesheet = "Sheet4" 'this is the sheet you wish to move them to
Z = 26 ' this is the number of columns to copy to the new sheet! sheetsList() = [{"Sheet6","Sheet7"}] ' place your sheet names here thetab = UBound(sheetsList) - LBound(sheetsList) + 1 For tabcounter = 1 To thetab For rowcounter = 1 To findlastrow(sheetsList(tabcounter)) For columnCount = 1 To Z thevalue = ThisWorkbook.Worksheets(sheetsList(tabcounter)).Cells(rowcounter, columnCount).Value ThisWorkbook.Worksheets(placesheet).Cells(findlastrow(placesheet) + 1, columnCount).Value = thevalue Next Next Next End Sub
Excuse me, and I understand this may be getting annoying, but in the fuction;
Function findlastrow(whatsheet)
findlastrow = ThisWorkbook.Worksheets(whatsheet).Cells(Rows.Count, 1).End(xlUp).Row
End Function
Then we are going back to before, so should it look like this:
Function findlastrow()
findlastrow = ThisWorkbook.Worksheets("Sheet4").Cells(Rows.Count, 1).End(xlUp).Row
End Function
It is not a problem. I just want you to learn amd be satisfied!
In order for program to run, the function CANNOT HAVE A SHEET HARDCODED INTO IT. We use that function to count the number of rows on ALL SHEETS, so it has to be able to accept a sheet name, or index number.
Function findlastrow()
findlastrow = ThisWorkbook.Worksheets().Cells(Rows.Count, 1).End(xlUp).Row
End Function
Sub CombineSheets()
'this code assumes your master sheet is on the first sheet
'It will loop through each sheet and place the contents onto the first sheet
Dim tabcount
Dim rowcounter
Dim thevalue
Dim Z
Dim sheetsList()
Dim placesheet
placesheet = "Sheet4" 'this is the sheet you wish to move them to
Z = 15 ' this is the number of columns to copy to the new sheet!
sheetsList() = [{"Sheet3","Sheet5","Sheet6","Sheet7"}]
thetab = UBound(sheetsList) - LBound(sheetsList) + 1
For tabcounter = 1 To thetab
For rowcounter = 1 To findlastrow(sheetsList(tabcounter))
For columnCount = 1 To Z
thevalue = ThisWorkbook.Worksheets(sheetsList(tabcounter)).Cells(rowcounter, columnCount).Value
ThisWorkbook.Worksheets(placesheet).Cells(findlastrow(placesheet) + 1, columnCount).Value = thevalue
Next
Next
Next
End Sub
This is what i Have now, and I am trying to figure out what "whatsheet" should be substitute by
Function findlastrow(whatsheet)
findlastrow = ThisWorkbook.Worksheets(whatsheet).Cells(Rows.Count, 1).End(xlUp).Row
End Function
Sub CombineSheets()
'this code assumes your master sheet is on the first sheet
'It will loop through each sheet and place the contents onto the first sheet
Dim tabcount
Dim rowcounter
Dim thevalue
Dim Z
Dim sheetsList()
Dim placesheet
placesheet = "Sheet4" 'this is the sheet you wish to move them to
Z = 15 ' this is the number of columns to copy to the new sheet!
sheetsList() = [{"Sheet3","Sheet5","Sheet6","Sheet7"}]
thetab = UBound(sheetsList) - LBound(sheetsList) + 1
For tabcounter = 1 To thetab
For rowcounter = 1 To findlastrow(sheetsList(tabcounter))
For columnCount = 1 To Z
thevalue = ThisWorkbook.Worksheets(sheetsList(tabcounter)).Cells(rowcounter, columnCount).Value
ThisWorkbook.Worksheets(placesheet).Cells(findlastrow(placesheet) + 1, columnCount).Value = thevalue
Next
Next
Next
End Sub
This si what i have now; i have listed the sheets i want to be copied to sheet 4, and the number of columns i want, however, it still wont run because of error 9. I feel like i am missing something dumb
it is ok. In the tools menu, select REFERENCES. Now see the image below, and make certain you are referencing the same packages as I do. Not just the highlighted on, but all with a checkbox! I am not abandoning you!
I dont think so, as the methods I am using is nothing new!
Do this. Remove that module from the workbook. Add in another blank module. Cut the code from your post above. And paste it into the new module. Try it again.
If it errors out, hit debug and take a screen shot of the yellow highlighted line that it is complaining about. Its good, we will work it.
it still errors, but i am unclear in what i am suppose to do so it may be an error on my end, all i am doing is placing the cursor and that line and the hitting F5
After it errors out, place ypur mouse over the variable of whatsheet, and tell me what ot thinks the variable is. I had you place the cursor there, so that I made certain you were running combinesheets to start it.
There is a Sheet 3, not a sheet called "Sheet 3"; but there is definetely one assigned to that value; in fact it is one of the specific one the array checks
Excuse me, what do you mean precisely by "the names of the tabs have to match the names on the list"? english is not my first language, and for me it seems to mean that the name on the list in the vba screen has to be the same as the tabs in the excel and in the code
OH! Hold on, there is a sheet called "Sheet 3", it's sheet 9, i just forgot about it, because it is hidden. I use it to create a dependant dropt list somwhere else
OK, I scaled out the previous posted code, and it was not presenting a large dataset correctly. I have posted a correction to the code. This is not going to fix a runtime 9 error!
Function findlastrow(whatsheet) findlastrow = ThisWorkbook.Worksheets(whatsheet).Cells(Rows.Count, 1).End(xlUp).Row End Function
Run the below code, it calls the one above!
Sub CombineSheets() 'Start here. This code will loop through 'each sheet in the sheetsList() array, 'and places the contents onto the sheet identified in placesheet '!The list names in sheetList() must Match the Sheet names!
Dim tabcount, rowcounter, Z Dim thevalue Dim sheetsList() Dim placesheet, placesheetrow
placesheet = "Sheet1" 'this is the sheet you wish to move them to
Z = 15 ' this is the number of columns to copy to the new sheet! sheetsList() = [{"Sheet3","Sheet4","Sheet2"}] 'this is the sheet list thetab = UBound(sheetsList) - LBound(sheetsList) + 1 For tabcounter = 1 To thetab For rowcounter = 1 To findlastrow(sheetsList(tabcounter)) placesheetrow = findlastrow(placesheet) + 1 For columnCount = 1 To Z thevalue = ThisWorkbook.Worksheets(sheetsList(tabcounter)).Cells(rowcounter, columnCount).Value ThisWorkbook.Worksheets(placesheet).Cells(placesheetrow, columnCount).Value = thevalue Next Next Next End Sub
Hello Mark, I have been extremely busy with work and commuting between my home town and the big city; however I must thank you so much. Because after many tries and thanks to your help I managed to create the sheet as intended, in fact, i turned in the work yesterday, reason why I have been so busy and i have not been able to reply to your posts.
Many thanks, because without you, I wouldn't manage to complete the work in time, and as an extra, I learn quite a lot. Good riddance my friend, may we see each other again.
Thank you. I must say, good riddance is not a closure that English speakers use when saying you wish to see someone again. As a matter of fact, ypu say that when you wish to No Longer see them again.
Come back when you need more help! I am glad you have learned something.
- Posts
- 13029
- Registration date
- Monday June 3, 2013
- Status
- Member
- Last seen
- October 11, 2019
1,644Do you know how to build a " for loop " in VBA?